GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app: optionally pass cert with select-client-certificate event
fix code style
Have addressed the comments, thanks!
I'm not sure I understand this check for 2 here.
Calling callback(cert, null) would hit here and return early and not use the cert but calling callback(cert, null, null) would continue with the cert.
callback(cert, null, null)
What case is this targeting?
We want request to continue with nullptr when the callback is called with no arguments or null. Here callback has already two bound arguments on c++ side, so when callback() is called, the condition will be satisfied.
Oh awesome, totally makes sense, thanks for explaining 👍
Thanks for this @deepak1556 🚢