New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against missing devToolsWebContents #8144

Merged
merged 3 commits into from Dec 6, 2016

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented Dec 6, 2016

This fixes any issue where BrowserWindow.fromDevToolsWebContents would through an error if any of the windows didn't have the dev tools already opened.

@kevinsawicki kevinsawicki merged commit 3e128ab into master Dec 6, 2016

8 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #4875083 succeeded in 107s
Details
electron-linux-ia32 Build #4875084 succeeded in 106s
Details
electron-linux-x64 Build #4875085 succeeded in 170s
Details
electron-mas-x64 Build #2989 succeeded in 8 min 47 sec
Details
electron-osx-x64 Build #3002 succeeded in 9 min 6 sec
Details
electron-win-ia32 Build #2046 succeeded in 9 min 52 sec
Details
electron-win-x64 Build #2025 succeeded in 9 min 57 sec
Details

@kevinsawicki kevinsawicki deleted the from-devtools-webcontents-fix branch Dec 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment