New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record JavaScript calls in DevTools timeline on Node/ipc callback #8159

Merged
merged 2 commits into from Dec 12, 2016

Conversation

Projects
None yet
2 participants
@seanchas116
Contributor

seanchas116 commented Dec 7, 2016

Fix for #7920, using TRACE_EVENT API of Chromium.

Looks like below in this example

image

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Dec 12, 2016

Contributor

Thanks so much @seanchas116 for fixing this, it is awesome to have these in the timeline now 👍 🚢

Contributor

kevinsawicki commented Dec 12, 2016

Thanks so much @seanchas116 for fixing this, it is awesome to have these in the timeline now 👍 🚢

@kevinsawicki kevinsawicki merged commit 2e1e893 into electron:master Dec 12, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment