New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing with the sandbox enabled #8165

Merged
merged 1 commit into from Dec 12, 2016

Conversation

Projects
None yet
4 participants
@geoff-addepar
Contributor

geoff-addepar commented Dec 8, 2016

Closes #7984

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Dec 8, 2016

/cc @tarruda want to review this one?

@tarruda

This comment has been minimized.

Contributor

tarruda commented Dec 8, 2016

While I'm not familiar with the printing API, the usage seems to be the same as in AtomRendererClient, so LGTM.

@hokein

This comment has been minimized.

Contributor

hokein commented Dec 11, 2016

LGTM on printing API part.

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Dec 12, 2016

Thanks @geoff-addepar for this 👍 🚢

Thanks @hokein and @tarruda for reviewing 👍 👀

@kevinsawicki kevinsawicki merged commit 1a0fbf8 into electron:master Dec 12, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment