New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow buttons to be optional in 'showMessageBox' #8187

Merged
merged 1 commit into from Dec 12, 2016

Conversation

Projects
None yet
2 participants
@danhp
Member

danhp commented Dec 12, 2016

Closes #1868

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Dec 12, 2016

Contributor

Thanks @danhp, looks great 👍

Contributor

kevinsawicki commented Dec 12, 2016

Thanks @danhp, looks great 👍

@kevinsawicki kevinsawicki merged commit cb7715a into master Dec 12, 2016

6 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #3013 succeeded in 8 min 28 sec
Details
electron-osx-x64 Build #3026 succeeded in 8 min 55 sec
Details
electron-win-ia32 Build #2069 succeeded in 7 min 41 sec
Details
electron-win-x64 Build #2048 succeeded in 7 min 43 sec
Details

@kevinsawicki kevinsawicki deleted the optional-buttons branch Dec 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment