New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined browser causes error in dialog APIs #8189

Merged
merged 2 commits into from Dec 13, 2016

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented Dec 13, 2016

null was handled but undefined results in a Cannot read property 'constructor' of undefined error.

@kevinsawicki kevinsawicki merged commit 8ae7d01 into master Dec 13, 2016

4 of 7 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-osx-x64 Build #3031 in progress...
Details
electron-linux-arm Build #4940006 succeeded in 64s
Details
electron-linux-ia32 Build #4940007 succeeded in 61s
Details
electron-linux-x64 Build #4940008 succeeded in 129s
Details
electron-mas-x64 Build #3019 succeeded in 7 min 34 sec
Details

@kevinsawicki kevinsawicki deleted the undefined-browser-window-in-dialog branch Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment