New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash when window is closed by dialog callback #8252

merged 2 commits into from Dec 22, 2016


None yet
1 participant

kevinsawicki commented Dec 21, 2016

Use a NativeWindowObserver to ensure a closed window is not accessed when the dialog completes and it is trying to re-enable the parent dialog.

Closes #7838

@kevinsawicki kevinsawicki merged commit 57d682a into master Dec 22, 2016

0 of 5 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
continuous-integration/travis-ci/pr The Travis CI build is in progress
electron-linux-arm Build #5030380 started
electron-linux-ia32 Build #5030381 queued
electron-linux-x64 Build #5030382 queued

@kevinsawicki kevinsawicki deleted the dialog-window-crash branch Dec 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment