Don't crash when window is closed by dialog callback #8252

Merged
merged 2 commits into from Dec 22, 2016

Projects

None yet

1 participant

@kevinsawicki
Contributor

Use a NativeWindowObserver to ensure a closed window is not accessed when the dialog completes and it is trying to re-enable the parent dialog.

Closes #7838

kevinsawicki added some commits Dec 20, 2016
@kevinsawicki kevinsawicki Observe window and only use it when it is open 87f0913
@kevinsawicki kevinsawicki Add override
8c5f263
@kevinsawicki kevinsawicki merged commit 57d682a into master Dec 22, 2016

0 of 5 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #5030380 started
Details
electron-linux-ia32 Build #5030381 queued
Details
electron-linux-x64 Build #5030382 queued
Details
@kevinsawicki kevinsawicki deleted the dialog-window-crash branch Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment