New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cursive/fantasy default font families #8295

Merged
merged 1 commit into from Dec 28, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Dec 28, 2016

Allows the cursive and fantasy font families to be configurable via the web preferences.

Closes #8286

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Dec 28, 2016

Member

From the CSS Spec:

Fantasy fonts, as used in CSS, are primarily decorative while still containing representations of characters (as opposed to Pi or Picture fonts, which do not represent characters). Examples include:

Why Impact? Because it's one of the so-called "core fonts for the web"?

screen shot 2016-12-28 at 11 07 21 am

Member

zeke commented Dec 28, 2016

From the CSS Spec:

Fantasy fonts, as used in CSS, are primarily decorative while still containing representations of characters (as opposed to Pi or Picture fonts, which do not represent characters). Examples include:

Why Impact? Because it's one of the so-called "core fonts for the web"?

screen shot 2016-12-28 at 11 07 21 am

@kevinsawicki kevinsawicki merged commit 219693d into master Dec 28, 2016

0 of 5 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #5056216 queued
Details
electron-linux-ia32 Build #5056217 queued
Details
electron-linux-x64 Build #5056218 queued
Details

@kevinsawicki kevinsawicki deleted the more-default-font-families branch Dec 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment