New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroy web contents if new-window event is prevented #8377

Merged
merged 4 commits into from Jan 12, 2017

Conversation

Projects
None yet
4 participants
@kevinsawicki
Contributor

kevinsawicki commented Jan 10, 2017

This pull request seeks to prevent a crash when calling preventDefault() on a new-window event emitted from a sandboxed renderer process.

@zcbenz was this what you were thinking for #7490 (comment)?

Fixes #7490

@kevinsawicki kevinsawicki requested a review from tarruda Jan 10, 2017

Show outdated Hide outdated spec/api-browser-window-spec.js Outdated
@zcbenz

This comment has been minimized.

Show comment
Hide comment
@zcbenz

zcbenz Jan 11, 2017

Contributor

@zcbenz was this what you were thinking for #7490 (comment)?

I don't quite remember, but this PR looks good to me.

Contributor

zcbenz commented Jan 11, 2017

@zcbenz was this what you were thinking for #7490 (comment)?

I don't quite remember, but this PR looks good to me.

@kevinsawicki kevinsawicki merged commit 9ff1f6b into master Jan 12, 2017

7 of 9 checks passed

electron-linux-x64 Build #5167391 failed in 136s
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #5167389 succeeded in 73s
Details
electron-linux-ia32 Build #5167390 succeeded in 67s
Details
electron-mas-x64 Build #3141 succeeded in 7 min 43 sec
Details
electron-osx-x64 Build #3153 succeeded in 8 min 46 sec
Details
electron-win-ia32 Build #2185 succeeded in 12 min
Details
electron-win-x64 Build #2174 succeeded in 13 min
Details

@kevinsawicki kevinsawicki deleted the sandbox-open-crash branch Jan 12, 2017

@tarruda

This comment has been minimized.

Show comment
Hide comment
@tarruda

tarruda Jan 25, 2017

Contributor

My bad for not reviewing, somehow I didn't saw this notification.

Contributor

tarruda commented Jan 25, 2017

My bad for not reviewing, somehow I didn't saw this notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment