New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save a fullscreen state when Kiosk mode is called #8399

Merged
merged 2 commits into from Jan 17, 2017

Conversation

Projects
None yet
2 participants
@watilde
Member

watilde commented Jan 12, 2017

Hello!

This patch fixes #8338, and I've added some of the test cases related to the patch.

Here is an example code:

@@ -162,6 +162,8 @@ class NativeWindowMac : public NativeWindow,
bool is_kiosk_;
bool was_fullscreen_;

This comment has been minimized.

This comment has been minimized.

@watilde

watilde Jan 13, 2017

Member

Oh, I missed it! Thanks for your comment, I've updated.

@watilde

watilde Jan 13, 2017

Member

Oh, I missed it! Thanks for your comment, I've updated.

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Jan 17, 2017

Contributor

Thanks for fixing this 👍 🚢

Contributor

kevinsawicki commented Jan 17, 2017

Thanks for fixing this 👍 🚢

@kevinsawicki kevinsawicki merged commit f7bdf5d into electron:master Jan 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@watilde watilde deleted the watilde:feature/fixes-8338 branch Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment