New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gn chrome54 #8406

Merged
merged 39 commits into from Jan 19, 2017

Conversation

Projects
None yet
7 participants
@alespergl
Contributor

alespergl commented Jan 13, 2017

Complements libchromiumcontent #254

Fixes #6571
Fixes #7814
Fixes #8062
Fixes #8366
Fixes #8405

@zcbenz zcbenz force-pushed the use_gn-chrome54 branch from 02a9855 to 04f7417 Jan 17, 2017

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jan 17, 2017

I have rebased this branch on master, ready to merge now.

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Jan 17, 2017

Rebased this on top of latest master to pull in #8348

@poiru poiru force-pushed the use_gn-chrome54 branch from 7dc75eb to a560df3 Jan 19, 2017

@poiru

This comment has been minimized.

Member

poiru commented Jan 19, 2017

Fixed compiling Node on Windows (patch upstreamed) and rebased on top of latest master.

@poiru poiru force-pushed the use_gn-chrome54 branch 8 times, most recently from 78b746b to a560df3 Jan 19, 2017

@kevinsawicki kevinsawicki merged commit 22b21d0 into master Jan 19, 2017

3 of 6 checks passed

electron-mas-x64 Build #3197 failed in 9 min 26 sec
Details
electron-osx-x64 Build #3206 failed in 10 min
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-win-ia32 Build #2235 succeeded in 12 min
Details
electron-win-x64 Build #2222 succeeded in 12 min
Details
@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Jan 19, 2017

Thanks @alespergl and @poiru 🚢 🚢 🚢

Going to release this as a beta 1.5.0 to npm now.

@kevinsawicki kevinsawicki deleted the use_gn-chrome54 branch Jan 19, 2017

@herrmannplatz

This comment has been minimized.

Contributor

herrmannplatz commented Jan 19, 2017

Great job. Looking forward to give it a try.

@gregor

This comment has been minimized.

gregor commented Jan 21, 2017

@kevinsawicki What is the eta for the beta?

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Jan 21, 2017

What is the eta for the beta?

We hit a linker error on macOS when building the release builds, we are working on upgrading Xcode versions on CI to resolve this.

Assuming the builds/tests are successful after the upgrade, we will release the beta on Monday or Tuesday.

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Jan 24, 2017

1.5.0 is now published as a prerelease to npm under the beta tag.

You can install it via npm install electron@1.5.0 or npm install electron@beta, please open new issues for any regressions found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment