Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "context-menu" DOM event to <webview> #8409

Merged

Conversation

@javan
Copy link
Contributor

@javan javan commented Jan 13, 2017

It wasn't obvious to me how to add a test for this. I'm new to the codebase, and didn't see anything similar in webview-spec.js. Happy to add one if you point me in the right direction. Also happy to add docs, if you'd like.

Confirmed working locally:
screen shot 2017-01-13 at 5 08 35 pm

@kevinsawicki
Copy link
Contributor

@kevinsawicki kevinsawicki commented Jan 16, 2017

Thanks for adding this @javan 👍 🚢

@kevinsawicki kevinsawicki merged commit 9089d55 into electron:master Jan 16, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants