New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore thick frame full screen code path #8438

Merged
merged 1 commit into from Jan 18, 2017

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented Jan 18, 2017

This code was removed in #7765 because it was thought to no longer be needed but looks like it is needed or else a full screen transparent window will have a white background on Windows.

/cc @liusy182

Refs #8321 (comment)
Fixes #8439

@kevinsawicki kevinsawicki changed the title from Restore thick frame full screen path to Restore thick frame full screen code path Jan 18, 2017

@kevinsawicki kevinsawicki merged commit a7891e5 into master Jan 18, 2017

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #5217711 succeeded in 65s
Details
electron-linux-ia32 Build #5217712 succeeded in 59s
Details
electron-linux-x64 Build #5217713 succeeded in 130s
Details
@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Jan 18, 2017

Contributor

Merging this to get this out in the next release since this fixes a regression.

Contributor

kevinsawicki commented Jan 18, 2017

Merging this to get this out in the next release since this fixes a regression.

@kevinsawicki kevinsawicki deleted the restore-thick-frame-fullscreen-handler branch Jan 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment