New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolvesAliases option to openDialog #8617

Merged
merged 4 commits into from Feb 13, 2017

Conversation

Projects
None yet
4 participants
@MarshallOfSound
Member

MarshallOfSound commented Feb 7, 2017

Fixes #8601

Thanks for the detailed issue report @maxbrunsfeld was wondering what was causing this in a different Electron app for a while 馃槅

@kevinsawicki kevinsawicki self-assigned this Feb 7, 2017

@kevinsawicki kevinsawicki merged commit 8c2cf03 into master Feb 13, 2017

3 of 7 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-mas-x64 Build #3399 in progress...
Details
electron-win-x64 Build #2396 in progress...
Details
electron-linux-arm Build #5493644 succeeded in 66s
Details
electron-linux-ia32 Build #5493645 succeeded in 60s
Details
electron-linux-x64 Build #5493646 succeeded in 133s
Details
@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Feb 13, 2017

Contributor

Thanks for this @MarshallOfSound 馃殺

Contributor

kevinsawicki commented Feb 13, 2017

Thanks for this @MarshallOfSound 馃殺

@kevinsawicki kevinsawicki deleted the resolves-aliases-nsopen branch Feb 13, 2017

@maxbrunsfeld

This comment has been minimized.

Show comment
Hide comment
@maxbrunsfeld

maxbrunsfeld Feb 13, 2017

Contributor

Yeah, thanks @MarshallOfSound!

Contributor

maxbrunsfeld commented Feb 13, 2017

Yeah, thanks @MarshallOfSound!

@dmitry-zakablukov

This comment has been minimized.

Show comment
Hide comment
@dmitry-zakablukov

dmitry-zakablukov Mar 16, 2018

@MarshallOfSound , can the option noResolveAliases be also applied to Windows symbolic links? Now it has no effect on Windows and I get resolved paths from remote.dialog.showOpenDialog.

dmitry-zakablukov commented Mar 16, 2018

@MarshallOfSound , can the option noResolveAliases be also applied to Windows symbolic links? Now it has no effect on Windows and I get resolved paths from remote.dialog.showOpenDialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment