New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support updating crash reporter extra parameters #8648

Merged
merged 12 commits into from Feb 14, 2017

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Feb 9, 2017

This pull request adds a crashReporter.setExtraReporter which can be used on macOS to set additional fields to be sent after the initial values are passed to start.

On Linux and Windows this can be done by calling start a second time and the docs have been updated to reflect that.

  • Add tests

Closes #7100

@kevinsawicki kevinsawicki changed the title from Document how to adjust the crash reporter extra parameters to Support updating crash reporter extra parameters Feb 14, 2017

@kevinsawicki kevinsawicki merged commit 897d58b into master Feb 14, 2017

7 of 9 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #5511129 succeeded in 66s
Details
electron-linux-ia32 Build #5511130 succeeded in 61s
Details
electron-linux-x64 Build #5511131 succeeded in 135s
Details
electron-mas-x64 Build #3423 succeeded in 8 min 11 sec
Details
electron-osx-x64 Build #3432 succeeded in 8 min 28 sec
Details
electron-win-ia32 Build #2436 succeeded in 7 min 53 sec
Details
electron-win-x64 Build #2418 succeeded in 8 min 1 sec
Details

@kevinsawicki kevinsawicki deleted the set-extra-crash-reporter-data branch Feb 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment