Prevent invisible windows from being activated #8676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsawicki
force-pushed
the
focus-delegate
branch
3 times, most recently
from
79430b7
to
44443f5
Compare
kevinsawicki
changed the title
kevinsawicki
force-pushed
the
focus-delegate
branch
from
44443f5
to
98ed93d
Compare
kevinsawicki
changed the title
kevinsawicki
force-pushed
the
focus-delegate
branch
2 times, most recently
from
2eeb87f
to
7aebf96
Compare
kevinsawicki
changed the title
kevinsawicki
force-pushed
the
focus-delegate
branch
from
886a589
to
70849de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a
Activateoverride to the native aura widget used on Windows and only activates it when the window is visible so the currently focused window doesn't get incorrectly blurred when an invisible window is created.The focus manager appears to have changed in Chrome 56 and focusing a web contents in an invisible window causes the focused window to lose focus even though the invisible window cannot gain focus.
https://chromium.googlesource.com/chromium/src/+/5c16e0e849526c1c627e08a05351ab38a9cfbcf1%5E%21/#F7
Closes #8649