New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent invisible windows from being activated #8676

Merged
merged 7 commits into from Feb 15, 2017

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Feb 14, 2017

This pull request adds a Activate override to the native aura widget used on Windows and only activates it when the window is visible so the currently focused window doesn't get incorrectly blurred when an invisible window is created.

The focus manager appears to have changed in Chrome 56 and focusing a web contents in an invisible window causes the focused window to lose focus even though the invisible window cannot gain focus.

https://chromium.googlesource.com/chromium/src/+/5c16e0e849526c1c627e08a05351ab38a9cfbcf1%5E%21/#F7

  • Add tests

Closes #8649

@kevinsawicki kevinsawicki changed the title from Implement CanFocus window delegate and map to window state to [WIP] Implement CanFocus delegate and map to window state Feb 14, 2017

@kevinsawicki kevinsawicki changed the title from [WIP] Implement CanFocus delegate and map to window state to Implement CanFocus delegate and map to window state Feb 14, 2017

@kevinsawicki kevinsawicki changed the title from Implement CanFocus delegate and map to window state to Prevent invisible windows from being activated Feb 14, 2017

@kevinsawicki kevinsawicki merged commit 9a7ac53 into master Feb 15, 2017

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #5524739 succeeded in 68s
Details
electron-linux-ia32 Build #5524740 succeeded in 61s
Details
electron-linux-x64 Build #5524741 succeeded in 133s
Details
electron-mas-x64 Build #3432 succeeded in 8 min 5 sec
Details
electron-osx-x64 Build #3443 succeeded in 8 min 27 sec
Details
electron-win-ia32 Build #2447 succeeded in 7 min 58 sec
Details
electron-win-x64 Build #2428 succeeded in 8 min 0 sec
Details

@kevinsawicki kevinsawicki deleted the focus-delegate branch Feb 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment