New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use electron version in Chromedriver asset name #8682

Merged
merged 1 commit into from Feb 15, 2017

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Feb 14, 2017

Put the electron version in the asset name of the Chromedriver asset that ships with each new minor Electron release.

This prevents issue with caching by asset name and also makes it consistent with the ffmpeg and mksnapshot asset names.

Fixes #8653

@kevinsawicki kevinsawicki merged commit 0ac3969 into master Feb 15, 2017

5 of 9 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-mas-x64 Build #3431 in progress...
Details
electron-win-x64 Build #2427 in progress...
Details
electron-linux-arm Build #5524625 succeeded in 66s
Details
electron-linux-ia32 Build #5524626 succeeded in 61s
Details
electron-linux-x64 Build #5524627 succeeded in 133s
Details
electron-osx-x64 Build #3442 succeeded in 8 min 19 sec
Details
electron-win-ia32 Build #2446 succeeded in 8 min 6 sec
Details

@kevinsawicki kevinsawicki deleted the use-electron-version-in-chromedriver-asset-name branch Feb 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment