New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use owner browser window in pepper context menu #8739

Merged
merged 3 commits into from Feb 24, 2017

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Feb 22, 2017

In a fullscreen flash player, BrowserWindow.getFocusedWindow() will return null which causes the popup menu to throw an exception.

This pull request switches it to use webContents.getOwnerBrowserWindow() instead.

Closes #8632

@kevinsawicki kevinsawicki merged commit d01250e into master Feb 24, 2017

8 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #5636457 succeeded in 66s
Details
electron-linux-ia32 Build #5636458 succeeded in 60s
Details
electron-linux-x64 Build #5636459 succeeded in 138s
Details
electron-mas-x64 Build #3493 succeeded in 8 min 11 sec
Details
electron-osx-x64 Build #3504 succeeded in 8 min 50 sec
Details
electron-win-ia32 Build #2511 succeeded in 8 min 0 sec
Details
electron-win-x64 Build #2486 succeeded in 8 min 3 sec
Details

@kevinsawicki kevinsawicki deleted the pepper-context-menu branch Feb 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment