New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route webview window visibility change events in browser process #8742

Merged
merged 4 commits into from Feb 28, 2017

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Feb 22, 2017

This removes the need for an ipcRenderer listener in web-view.js to forward the window visibility event and instead co-locates it with the other embedder events listened for in guest-view-internal.js.

This prevents an event emitter warning when more than 10 web views exist in a window since webContents already has max listeners set to Infinity.

The other option to prevent this warning would be to bump the ipcRenderer max listeners to Infinity as well but that would seem to possibly cover up legit memory leaks in apps.

Closes #8622

@kevinsawicki kevinsawicki changed the title from Register window visibility listener when attached to Route webview window visibility change events in browser process Feb 24, 2017

@kevinsawicki kevinsawicki merged commit 51d6a55 into master Feb 28, 2017

8 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #5678472 succeeded in 66s
Details
electron-linux-ia32 Build #5678473 succeeded in 61s
Details
electron-linux-x64 Build #5678474 succeeded in 139s
Details
electron-mas-x64 Build #3525 succeeded in 8 min 12 sec
Details
electron-osx-x64 Build #3532 succeeded in 8 min 21 sec
Details
electron-win-ia32 Build #2543 succeeded in 8 min 2 sec
Details
electron-win-x64 Build #2514 succeeded in 8 min 6 sec
Details

@kevinsawicki kevinsawicki deleted the webview-visibility branch Feb 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment