Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add option to use native window.open() in non-sandboxed webcontents #8963
This pull request adds
It would be useful when you opens dialogs or preferences windows from your app, as it allows synchronous access to DOM elements in the new windows.
I don't know the risk of running multiple Node contexts in the same process, so I would be glad to know it.
Looks like reloading doesn't work well in this mode currently.
Thanks so much for the work. I really need this.
It seems like it has a bug with webview. Try this:
Go to Log in > Login with Google, Electron will crash.
Update: It's related to #8378, not this PR.