New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

TouchBar - Method to set escape button #9023

Merged
merged 14 commits into from Apr 4, 2017

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Member

MarshallOfSound commented Mar 27, 2017

Fixes #8937

In order to set an "Exit Fullscreen" button as pictured in the linked issue, you would construct an TouchBarButton manually and provide it an image 馃憤

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Mar 27, 2017

Member

Off note, this also adds some of the native capabilities required for #8888, mostly to do with adding non-default touch bar items 馃憤

Member

MarshallOfSound commented Mar 27, 2017

Off note, this also adds some of the native capabilities required for #8888, mostly to do with adding non-default touch bar items 馃憤

Show outdated Hide outdated atom/browser/api/atom_api_window.h
Show outdated Hide outdated atom/browser/native_window_mac.mm
Show outdated Hide outdated atom/browser/ui/cocoa/atom_touch_bar.h
Show outdated Hide outdated atom/browser/ui/cocoa/atom_touch_bar.h
Show outdated Hide outdated lib/browser/api/touch-bar.js
Show outdated Hide outdated lib/browser/api/touch-bar.js
Show outdated Hide outdated docs/api/touch-bar.md
@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound
Member

MarshallOfSound commented Mar 29, 2017

@kevinsawicki Updated 馃憤

@kevinsawicki kevinsawicki self-assigned this Mar 29, 2017

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Mar 29, 2017

Contributor

This is awesome to have, great work @MarshallOfSound.

I pushed a few changes, primarily around wiring up the change and interaction events for the escape item. When I was testing it I noticed the escape item button I was using wasn't calling my click function.

Also added a forward declaration for escapeKeyReplacementItemIdentifier so it compiles against 10.10 SDK.

Contributor

kevinsawicki commented Mar 29, 2017

This is awesome to have, great work @MarshallOfSound.

I pushed a few changes, primarily around wiring up the change and interaction events for the escape item. When I was testing it I noticed the escape item button I was using wasn't calling my click function.

Also added a forward declaration for escapeKeyReplacementItemIdentifier so it compiles against 10.10 SDK.

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Apr 3, 2017

Contributor

I've switched to a escapeItem property and an options-based TouchBar constructor.

This flushed out a few bugs in the remote module that need to land before the specs in this pull request go green, #9097 and #9101

Contributor

kevinsawicki commented Apr 3, 2017

I've switched to a escapeItem property and an options-based TouchBar constructor.

This flushed out a few bugs in the remote module that need to land before the specs in this pull request go green, #9097 and #9101

@kevinsawicki kevinsawicki merged commit 8c8b737 into master Apr 4, 2017

7 of 9 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #6110237 succeeded in 74s
Details
electron-linux-ia32 Build #6110238 succeeded in 66s
Details
electron-linux-x64 Build #6110239 succeeded in 150s
Details
electron-mas-x64 Build #3819 succeeded in 8 min 38 sec
Details
electron-osx-x64 Build #3816 succeeded in 8 min 54 sec
Details
electron-win-ia32 Build #2808 succeeded in 8 min 19 sec
Details
electron-win-x64 Build #2780 succeeded in 8 min 21 sec
Details
@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Apr 4, 2017

Contributor

Thanks @MarshallOfSound 馃憤 馃殺

Contributor

kevinsawicki commented Apr 4, 2017

Thanks @MarshallOfSound 馃憤 馃殺

@kevinsawicki kevinsawicki deleted the touchbar-set-escape-button branch Apr 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment