New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash happened in UvRunOnce #9043

Merged
merged 1 commit into from Mar 29, 2017

Conversation

Projects
None yet
3 participants
@zcbenz
Contributor

zcbenz commented Mar 28, 2017

When doing navigation without restarting renderer process, it may happen that the node environment is destroyed but the message loop is still there. In this case we should not run uv loop.

Fix #9004.

@kevinsawicki

LGTM

@zcbenz zcbenz merged commit 9ef1f8c into master Mar 29, 2017

8 of 9 checks passed

electron-osx-x64 Build #3738 failed in 12 min
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #6015788 succeeded in 72s
Details
electron-linux-ia32 Build #6015789 succeeded in 64s
Details
electron-linux-x64 Build #6015790 succeeded in 146s
Details
electron-mas-x64 Build #3739 succeeded in 8 min 36 sec
Details
electron-win-ia32 Build #2740 succeeded in 8 min 22 sec
Details
electron-win-x64 Build #2714 succeeded in 8 min 18 sec
Details

@zcbenz zcbenz deleted the fix-uv-run-crash branch Mar 29, 2017

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Mar 29, 2017

Contributor

Awesome guys ❤️

Contributor

bpasero commented Mar 29, 2017

Awesome guys ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment