New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing selected pages on Windows #9044

Merged
merged 1 commit into from Apr 4, 2017

Conversation

Projects
None yet
3 participants
@rreimann
Contributor

rreimann commented Mar 28, 2017

Fixes #8489

Fix printing selected pages by backporting https://bugs.chromium.org/p/chromium/issues/detail?id=553446

@rreimann

This comment has been minimized.

Contributor

rreimann commented Apr 1, 2017

After being reviewed/verified on the 1-4-x branch this fix should be merged into master as well.

Although the essential line is contained in the current Chromium version 56.0.2924.87 it's missing in chromium_src on electron master - so it looks like an oversight during the Chromium 56 upgrade #8501. /cc @zcbenz

@rreimann rreimann referenced this pull request Apr 1, 2017

Closed

Upgrade to Chrome 57 #8993

@hokein

hokein approved these changes Apr 1, 2017

Looks good. Thanks for tracking it.

@rreimann

This comment has been minimized.

Contributor

rreimann commented Apr 2, 2017

@hokein thanks for reviewing & approving the PR. Is there a chance to get the fix into a v1.4.16 release any time soon?

@kevinsawicki kevinsawicki merged commit 634eb67 into electron:1-4-x Apr 4, 2017

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Apr 4, 2017

Thanks for this @rreimann 👍 I'll work on a 1.4.16 this week.

@rreimann rreimann deleted the rreimann:1-4-x branch Apr 5, 2017

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Apr 5, 2017

@rreimann if #9111 is merged and released in 1.6, would you still want a 1.4 release with this in it?

@rreimann

This comment has been minimized.

Contributor

rreimann commented Apr 5, 2017

@kevinsawicki yes i would still need a 1.4x release since our application is not yet ready for the 1.6/Chrome 56 update.

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Apr 5, 2017

@rreimann this has been released in 1.4.16, thanks again for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment