New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface errors setting remote properties #9097

Merged
merged 2 commits into from Apr 3, 2017

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented Apr 3, 2017

Currently if you have a remote setter that throws an exception in the main process, that exception is not surfaced in the renderer process. This is because the IPC response was previously not parsed so any errors in it were ignored.

This pull request wraps the setter response in a metaToValue call so that errors from the main process are re-thrown in the render process, similar to getters and function calls.

Noticed this while working on #9023

@kevinsawicki kevinsawicki merged commit 7860ea0 into master Apr 3, 2017

7 of 9 checks passed

electron-win-ia32 Build #2788 failed in 8 min 44 sec
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #6092245 was skipped due to a previously successful build of the same tree.
Details
electron-linux-ia32 Build #6092246 was skipped due to a previously successful build of the same tree.
Details
electron-linux-x64 Build #6092247 was skipped due to a previously successful build of the same tree.
Details
electron-mas-x64 Build #3799 succeeded in 8 min 27 sec
Details
electron-osx-x64 Build #3796 succeeded in 8 min 51 sec
Details
electron-win-x64 Build #2760 succeeded in 8 min 23 sec
Details

@kevinsawicki kevinsawicki deleted the handle-setter-errors branch Apr 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment