New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick node fix for ChildProcess.fork --eval bug #9132

Merged
merged 3 commits into from Apr 6, 2017

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented Apr 6, 2017

Pulls in nodejs/node#11958 which fixed nodejs/node#11948

Fix landed upstream in nodejs/node@9ff7ed2 and this was cherry-picked into our node fork as electron/node@3fe90cf

This patch can be dropped once we upgrade to Node 7.8

/cc @bpasero

Closes #8944

@kevinsawicki kevinsawicki changed the title from Cherry pick node for for ChildProcess.fork --eval bug to Cherry pick node fix for ChildProcess.fork --eval bug Apr 6, 2017

@kevinsawicki kevinsawicki merged commit e3407bb into master Apr 6, 2017

8 of 9 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #6137233 succeeded in 74s
Details
electron-linux-ia32 Build #6137234 succeeded in 68s
Details
electron-linux-x64 Build #6137235 succeeded in 152s
Details
electron-mas-x64 Build #3848 succeeded in 8 min 30 sec
Details
electron-osx-x64 Build #3841 succeeded in 9 min 8 sec
Details
electron-win-ia32 Build #2831 succeeded in 8 min 16 sec
Details
electron-win-x64 Build #2805 succeeded in 8 min 20 sec
Details

@kevinsawicki kevinsawicki deleted the fork-eval-node-fix branch Apr 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment