New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set NSScrollViewRubberbanding scroll bounce pref #9134

Merged
merged 1 commit into from Apr 11, 2017

Conversation

Projects
None yet
4 participants
@kevinsawicki
Contributor

kevinsawicki commented Apr 6, 2017

Previously Electron was only ever setting this pref to false when the scrollBounce web preferences was set false.

Now it is always set, and set to true when enabled so Chrome picks it up and enables it on the renderer.

scroll-bounce

Refs #5412
Closes #9033

@kevinsawicki kevinsawicki requested a review from zcbenz Apr 6, 2017

@kevinsawicki kevinsawicki merged commit a30cf30 into master Apr 11, 2017

7 of 9 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #6194089 succeeded in 73s
Details
electron-linux-ia32 Build #6194090 succeeded in 101s
Details
electron-linux-x64 Build #6194091 succeeded in 188s
Details
electron-mas-x64 Build #3879 succeeded in 8 min 38 sec
Details
electron-osx-x64 Build #3870 succeeded in 8 min 50 sec
Details
electron-win-ia32 Build #2860 succeeded in 8 min 17 sec
Details
electron-win-x64 Build #2833 succeeded in 8 min 28 sec
Details

@kevinsawicki kevinsawicki deleted the scroll-bounce-fix branch Apr 11, 2017

@Dexwell

This comment has been minimized.

Show comment
Hide comment
@Dexwell

Dexwell May 11, 2017

I was expecting this setting to enable scroll bouncing for DOM elements such as scrollable divs, but it only seems to apply to the BrowserWindow itself. Per Chromium #546520 it seems like this won't be possible soon.

Dexwell commented May 11, 2017

I was expecting this setting to enable scroll bouncing for DOM elements such as scrollable divs, but it only seems to apply to the BrowserWindow itself. Per Chromium #546520 it seems like this won't be possible soon.

@ianpaschal

This comment has been minimized.

Show comment
Hide comment
@ianpaschal

ianpaschal May 30, 2017

Same. When using...

body, html {
  width: 100%;
  height: 100%;
  overflow: hidden;
}

...in Safari, only the body from bouncing but allows DOM elements to, as it though.

...in Chromium, however, no-go. :(

ianpaschal commented May 30, 2017

Same. When using...

body, html {
  width: 100%;
  height: 100%;
  overflow: hidden;
}

...in Safari, only the body from bouncing but allows DOM elements to, as it though.

...in Chromium, however, no-go. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment