New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9128: Removed unused dll from distribution. #9157

Merged
merged 1 commit into from Apr 11, 2017

Conversation

Projects
None yet
3 participants
@cifratila
Member

cifratila commented Apr 10, 2017

Follow up: I don't have right to create a release here: https://github.com/electron/electron-frameworks/releases

At first I would publish the zip as before but without the xinput1_3.dll. Or even better we could modify: https://github.com/electron/electron/blob/master/script/update-external-binaries.py and download only d3dcompiler_47.dll

Fixes #9128

@cifratila cifratila requested review from zcbenz and kevinsawicki Apr 10, 2017

@kevinsawicki

LGTM

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Apr 11, 2017

Contributor

Thanks @cifratila 🚢

Contributor

kevinsawicki commented Apr 11, 2017

Thanks @cifratila 🚢

@kevinsawicki kevinsawicki merged commit b2761ab into master Apr 11, 2017

5 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #3870 succeeded in 8 min 29 sec
Details
electron-osx-x64 Build #3860 succeeded in 8 min 40 sec
Details
electron-win-ia32 Build #2850 succeeded in 8 min 20 sec
Details
electron-win-x64 Build #2825 succeeded in 8 min 29 sec
Details

@kevinsawicki kevinsawicki deleted the cifratila/remove-unused-dll branch Apr 11, 2017

@englishextra

This comment has been minimized.

Show comment
Hide comment
@englishextra

englishextra Jun 1, 2017

Does this mean that xinput1_3.dll removed while pdf_viewer_resources.pak added

Why asking? I had to manually change installers scripts, so would that be OK to change the above regarding migration from 1.6.2 to 1.6.10?

englishextra commented Jun 1, 2017

Does this mean that xinput1_3.dll removed while pdf_viewer_resources.pak added

Why asking? I had to manually change installers scripts, so would that be OK to change the above regarding migration from 1.6.2 to 1.6.10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment