New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cookie flush store api #9194

Merged
merged 4 commits into from Apr 18, 2017

Conversation

Projects
None yet
4 participants
@juturu
Contributor

juturu commented Apr 14, 2017

Fixes #8416

@juturu juturu requested a review from deepak1556 Apr 14, 2017

@MarshallOfSound

Docs thing 👍

Show outdated Hide outdated docs/api/cookies.md
@deepak1556

LGTM, thanks @juturu !

@deepak1556

This comment has been minimized.

Show comment
Hide comment
@deepak1556

deepak1556 Apr 17, 2017

Member

@juturu can you fix the cpplint issues with clang-format, CI builds are failing due to it. You can do npm run lint to verify locally.

Member

deepak1556 commented Apr 17, 2017

@juturu can you fix the cpplint issues with clang-format, CI builds are failing due to it. You can do npm run lint to verify locally.

@juturu

This comment has been minimized.

Show comment
Hide comment
@juturu

juturu Apr 17, 2017

Contributor

@deepak1556 fixed the lint issue. Merge at your convenience.

Contributor

juturu commented Apr 17, 2017

@deepak1556 fixed the lint issue. Merge at your convenience.

@@ -53,6 +53,7 @@ class Cookies : public mate::TrackableObject<Cookies>,
void Remove(const GURL& url, const std::string& name,
const base::Closure& callback);
void Set(const base::DictionaryValue& details, const SetCallback& callback);
void FlushStore(const base::Closure& callback);

This comment has been minimized.

@kevinsawicki

kevinsawicki Apr 18, 2017

Contributor

Could we add a test for this to api-session-spec.js that just verifies the callback is invoked? You don't need to assert more than that, but just to have basic coverage of this API.

@kevinsawicki

kevinsawicki Apr 18, 2017

Contributor

Could we add a test for this to api-session-spec.js that just verifies the callback is invoked? You don't need to assert more than that, but just to have basic coverage of this API.

@kevinsawicki kevinsawicki merged commit 1fe1040 into master Apr 18, 2017

0 of 5 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #6279742 queued
Details
electron-linux-ia32 Build #6279743 queued
Details
electron-linux-x64 Build #6279744 queued
Details

@kevinsawicki kevinsawicki deleted the external/cookie-flushstore-api branch Apr 18, 2017

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Apr 18, 2017

Contributor

Thanks for adding this @juturu 👍 🚀

Contributor

kevinsawicki commented Apr 18, 2017

Thanks for adding this @juturu 👍 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment