New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use document.write in default app #9249

Merged
merged 1 commit into from Apr 24, 2017

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented Apr 21, 2017

Previously this could lead to weird rendering issues if the resource path had certain characters in it since the content was interpreted as HTML.

Use innerText instead so paths are treated as text.

@kevinsawicki kevinsawicki merged commit c146f8a into master Apr 24, 2017

5 of 9 checks passed

electron-linux-x64 Build #6357241 failed in 24s
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-win-x64 Build #2956 in progress...
Details
electron-linux-arm Build #6357239 succeeded in 72s
Details
electron-linux-ia32 Build #6357240 succeeded in 65s
Details
electron-mas-x64 Build #3994 succeeded in 8 min 54 sec
Details
electron-osx-x64 Build #3995 succeeded in 8 min 33 sec
Details
electron-win-ia32 Build #2978 succeeded in 8 min 50 sec
Details

@kevinsawicki kevinsawicki deleted the document-write branch Apr 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment