New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit javascript preference in opened windows #9250

Merged
merged 4 commits into from Apr 25, 2017

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented Apr 21, 2017

Currently the nodeIntegration and contextIsolation web preferences are inherited in windows opened via window.open.

This pull request adds the javascript web preference to that list so that windows with JavaScript disabled cannot open windows with JavaScript enabled.

@kevinsawicki kevinsawicki merged commit c9ec45d into master Apr 25, 2017

6 of 9 checks passed

electron-win-x64 Build #2972 failed in 11 min
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #6376879 succeeded in 73s
Details
electron-linux-ia32 Build #6376880 succeeded in 65s
Details
electron-linux-x64 Build #6376881 succeeded in 153s
Details
electron-mas-x64 Build #4011 succeeded in 9 min 27 sec
Details
electron-osx-x64 Build #4013 succeeded in 9 min 46 sec
Details
electron-win-ia32 Build #2994 succeeded in 7 min 30 sec
Details

@kevinsawicki kevinsawicki deleted the inherit-javascript-option branch Apr 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment