New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert alert/confirm arguments to strings in render process #9252

Merged
merged 2 commits into from Apr 24, 2017

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented Apr 21, 2017

Currently if converting the message or title arguments to a string in the main process throws an exception then the IPC return value is never set and so the render process becomes unresponsive.

This pull request switches window.alert and window.confirm to convert the arguments to strings in the render process so the errors are properly thrown there which is the same behavior in standalone Chrome.

@kevinsawicki kevinsawicki merged commit 2e22328 into master Apr 24, 2017

3 of 8 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-x64 Build #6357428 started
Details
electron-mas-x64 Build #3996 in progress...
Details
electron-osx-x64 Build #3997 in progress...
Details
electron-linux-arm Build #6357426 succeeded in 195s
Details
electron-linux-ia32 Build #6357427 succeeded in 195s
Details
electron-win-x64 Build #2957 succeeded in 7 min 33 sec
Details

@kevinsawicki kevinsawicki deleted the convert-to-string-in-render-process branch Apr 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment