New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit auto updater error directly as Error #9255

Merged
merged 3 commits into from Apr 24, 2017

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented Apr 21, 2017

Previously the error was wrapped up as an event object which meant its stack and message properties were stripped from it when transferred over the remote module.

Now it is emitted directly as an Error object which keeps all its standard property descriptors.

/cc @joshaber

@kevinsawicki kevinsawicki merged commit b6192da into master Apr 24, 2017

7 of 9 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #6357753 succeeded in 71s
Details
electron-linux-ia32 Build #6357754 succeeded in 65s
Details
electron-linux-x64 Build #6357755 succeeded in 151s
Details
electron-mas-x64 Build #3999 succeeded in 8 min 58 sec
Details
electron-osx-x64 Build #4000 succeeded in 7 min 54 sec
Details
electron-win-ia32 Build #2982 succeeded in 8 min 42 sec
Details
electron-win-x64 Build #2961 succeeded in 7 min 37 sec
Details

@kevinsawicki kevinsawicki deleted the emit-auto-updater-error branch Apr 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment