New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable node integration in chrome-devtools URLs #9278

Merged
merged 2 commits into from Apr 26, 2017

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented Apr 24, 2017

This pull request update the renderer init.js script to disable node integration in chrome-devtools URLs.

The inspector.js script seems to only depend on require which will be available when node integration is disabled since the script is require-ed directly in init.js.

Tested this change manually and the dialog and menu still appeared in the dev tools.

@kevinsawicki kevinsawicki changed the title from Only enable node integration on devtools page if it wasn't explicitly disabled to Disable node integration in chrome-devtools URLs Apr 24, 2017

@kevinsawicki kevinsawicki merged commit 4e7e9d1 into master Apr 26, 2017

8 of 9 checks passed

electron-win-ia32 Build #2997 failed in 11 min
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #6377703 succeeded in 73s
Details
electron-linux-ia32 Build #6377704 succeeded in 65s
Details
electron-linux-x64 Build #6377705 succeeded in 152s
Details
electron-mas-x64 Build #4014 succeeded in 8 min 51 sec
Details
electron-osx-x64 Build #4016 succeeded in 9 min 25 sec
Details
electron-win-x64 Build #2975 succeeded in 7 min 55 sec
Details

@kevinsawicki kevinsawicki deleted the dont-override-argument-value branch Apr 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment