New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store frames to guest as Map #9287

Merged
merged 2 commits into from Apr 26, 2017

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Apr 25, 2017

Using an object for this mapping causes errors to be thrown if the frame name matched a built-in object property (like __proto__). Now it uses a Map which supports all frame names.

@kevinsawicki kevinsawicki changed the title from Store frames to guest as map to Store frames to guest as Map Apr 25, 2017

@YurySolovyov

This comment has been minimized.

Show comment
Hide comment
@YurySolovyov

YurySolovyov Apr 26, 2017

Contributor

Spotted any other places for this kind of cleanup?

Contributor

YurySolovyov commented Apr 26, 2017

Spotted any other places for this kind of cleanup?

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Apr 26, 2017

Contributor

Spotted any other places for this kind of cleanup?

Haven't seen any other obvious ones, most other object maps use generated ids that are incrementing numbers.

Contributor

kevinsawicki commented Apr 26, 2017

Spotted any other places for this kind of cleanup?

Haven't seen any other obvious ones, most other object maps use generated ids that are incrementing numbers.

@kevinsawicki kevinsawicki merged commit 0aa53f4 into master Apr 26, 2017

7 of 9 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #6389445 succeeded in 71s
Details
electron-linux-ia32 Build #6389446 succeeded in 67s
Details
electron-linux-x64 Build #6389447 succeeded in 153s
Details
electron-mas-x64 Build #4021 succeeded in 9 min 4 sec
Details
electron-osx-x64 Build #4023 succeeded in 9 min 27 sec
Details
electron-win-ia32 Build #3004 succeeded in 7 min 35 sec
Details
electron-win-x64 Build #2982 succeeded in 13 min
Details

@kevinsawicki kevinsawicki deleted the store-frames-to-guest-as-map branch Apr 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment