New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow webPreferences to be overridden in features string #9289

Merged
merged 2 commits into from Apr 26, 2017

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented Apr 25, 2017

Specifying a features string of webPreferences= would previously throw an uncaught main process exception since that options key is assumed to be an object.

This pull request prevents it from being set since the feature string isn't intended to support setting objects directly anyway. This does not change the behavior of setting other window options or web preferences from the features string.

@kevinsawicki kevinsawicki merged commit 8460a58 into master Apr 26, 2017

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #6390379 succeeded in 72s
Details
electron-linux-ia32 Build #6390380 succeeded in 65s
Details
electron-linux-x64 Build #6390381 succeeded in 154s
Details
electron-mas-x64 Build #4024 succeeded in 9 min 5 sec
Details
electron-osx-x64 Build #4026 succeeded in 9 min 32 sec
Details
electron-win-ia32 Build #3007 succeeded in 13 min
Details
electron-win-x64 Build #2985 succeeded in 7 min 47 sec
Details

@kevinsawicki kevinsawicki deleted the dont-allow-webpreferences-option-setting branch Apr 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment