New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use isSameOrigin helper when checking postMessage targetOrigin #9301

Merged
merged 4 commits into from May 1, 2017

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Apr 26, 2017

This helper is a better implementation than the current string checks and is used from the canAcccessWindow helper.

@kevinsawicki kevinsawicki requested a review from zcbenz Apr 27, 2017

@zcbenz

zcbenz approved these changes May 1, 2017

👍

@kevinsawicki kevinsawicki merged commit f84c75a into master May 1, 2017

7 of 9 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #6438284 succeeded in 72s
Details
electron-linux-ia32 Build #6438285 succeeded in 66s
Details
electron-linux-x64 Build #6438286 succeeded in 155s
Details
electron-mas-x64 Build #4055 succeeded in 7 min 36 sec
Details
electron-osx-x64 Build #4057 succeeded in 8 min 13 sec
Details
electron-win-ia32 Build #3041 succeeded in 9 min 57 sec
Details
electron-win-x64 Build #3015 succeeded in 9 min 57 sec
Details

@kevinsawicki kevinsawicki deleted the post-message-origin-check branch May 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment