New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context leak in ObjectLifeMonitor. #9314

Merged
merged 1 commit into from May 1, 2017

Conversation

Projects
None yet
3 participants
@tarruda
Contributor

tarruda commented Apr 27, 2017

The RemoteObjectFreer class is keeping the context alive even when the window is
closed. For electron applications that use sandbox, this will cause a memory
leak every time a new window is created with window.open.

Close #9191

Fix context leak in ObjectLifeMonitor.
The RemoteObjectFreer class is keeping the context alive even when the window is
closed. For electron applications that use sandbox, this will cause a memory
leak every time a new window is created with `window.open`.

Close #9191
@zcbenz

zcbenz approved these changes May 1, 2017

👍

@zcbenz zcbenz merged commit ca7ca3b into master May 1, 2017

5 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #4045 succeeded in 7 min 25 sec
Details
electron-osx-x64 Build #4047 succeeded in 8 min 18 sec
Details
electron-win-x64 Build #3006 succeeded in 7 min 50 sec
Details

@zcbenz zcbenz deleted the fix-windowopen-memory-leak branch May 1, 2017

@lneir lneir referenced this pull request May 2, 2017

Merged

upgrade to electron 1.6.8 #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment