New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mode prop to segmented touch bar control #9315

Merged
merged 3 commits into from May 4, 2017

Conversation

Projects
None yet
3 participants
@MarshallOfSound
Member

MarshallOfSound commented Apr 28, 2017

Fixes #9298

@MarshallOfSound MarshallOfSound requested a review from kevinsawicki Apr 28, 2017

@kevinsawicki

Implementation looks good, but needs a doc update for this new option.

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Apr 28, 2017

Member

@kevinsawicki Woops, looks like I closed my laptop lid before the last push finished 😆 Will push up the missing docs in the morning 👍

Member

MarshallOfSound commented Apr 28, 2017

@kevinsawicki Woops, looks like I closed my laptop lid before the last push finished 😆 Will push up the missing docs in the morning 👍

@rmaes4

This comment has been minimized.

Show comment
Hide comment
@rmaes4

rmaes4 Apr 30, 2017

is there a way I could test this out on my local machine?

rmaes4 commented Apr 30, 2017

is there a way I could test this out on my local machine?

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki May 1, 2017

Contributor

is there a way I could test this out on my local machine?

You can check out this branch and build Electron locally and then run npm start to launch the newly built version, https://electron.atom.io/docs/development/build-instructions-osx/

Contributor

kevinsawicki commented May 1, 2017

is there a way I could test this out on my local machine?

You can check out this branch and build Electron locally and then run npm start to launch the newly built version, https://electron.atom.io/docs/development/build-instructions-osx/

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki May 1, 2017

Contributor

Woops, looks like I closed my laptop lid before the last push finished 😆 Will push up the missing docs in the morning

@MarshallOfSound got a chance to push up these docs? 📝

Contributor

kevinsawicki commented May 1, 2017

Woops, looks like I closed my laptop lid before the last push finished 😆 Will push up the missing docs in the morning

@MarshallOfSound got a chance to push up these docs? 📝

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound May 2, 2017

Member

@MarshallOfSound got a chance to push up these docs? 📝

I always see these just as I'm heading to sleep 😆 I swear I'll push it up tomorrow morning 😉

Member

MarshallOfSound commented May 2, 2017

@MarshallOfSound got a chance to push up these docs? 📝

I always see these just as I'm heading to sleep 😆 I swear I'll push it up tomorrow morning 😉

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound May 3, 2017

Member

Not gonna lie, totally wasn't "in the morning", but they're up there now 😆 @kevinsawicki

Member

MarshallOfSound commented May 3, 2017

Not gonna lie, totally wasn't "in the morning", but they're up there now 😆 @kevinsawicki

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki May 4, 2017

Contributor

Thanks for this @MarshallOfSound 👍

Contributor

kevinsawicki commented May 4, 2017

Thanks for this @MarshallOfSound 👍

@kevinsawicki kevinsawicki merged commit eebae82 into master May 4, 2017

0 of 5 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #6496413 queued
Details
electron-linux-ia32 Build #6496414 queued
Details
electron-linux-x64 Build #6496415 queued
Details

@kevinsawicki kevinsawicki deleted the segmented-control-mode branch May 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment