Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
protocol: provide default response code for custom request jobs #9360
Service worker registration requires a successful response code https://cs.chromium.org/chromium/src/content/browser/service_worker/service_worker_write_to_cache_job.cc?l=285, until https://bugs.chromium.org/p/chromium/issues/detail?id=688481 gets landed we have to provide a default success response code.
@deepak1556 saw a weird crash on Windows CI:
Rebased and force pushed, will see if it happens again.
May 11, 2017
6 of 9 checks passed
Specs are green, merging this
@deepak1556 let me know if you think that crash was caused by this pull request, it happened before the added specs so I wasn't sure, it was right after