New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CPU and I/O metrics to process module #9373

Merged
merged 8 commits into from May 4, 2017

Conversation

Projects
None yet
3 participants
@juturu
Contributor

juturu commented May 4, 2017

No description provided.

@kevinsawicki

Looks good, left one minor comment.

Show outdated Hide outdated atom/common/api/atom_bindings.cc
@kevinsawicki

Left a few minor notes.

Show outdated Hide outdated spec/api-process-spec.js
Show outdated Hide outdated spec/api-process-spec.js
* `CPUUsage` [CPUUsage](structures/cpu-usage.md)
### `process.getIOCounters()` _Windows_ _Linux_

This comment has been minimized.

@kevinsawicki

kevinsawicki May 4, 2017

Contributor

Does this just return an empty object on macOS then?

@kevinsawicki

kevinsawicki May 4, 2017

Contributor

Does this just return an empty object on macOS then?

This comment has been minimized.

@juturu

juturu May 4, 2017

Contributor
Show outdated Hide outdated docs/api/structures/cpu-usage.md
Show outdated Hide outdated docs/api/structures/cpu-usage.md

juturu added some commits May 4, 2017

@kevinsawicki kevinsawicki merged commit 7003300 into master May 4, 2017

4 of 6 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-mas-x64 Build #4097 succeeded in 9 min 25 sec
Details
electron-osx-x64 Build #4100 succeeded in 8 min 29 sec
Details
electron-win-ia32 Build #3082 succeeded in 9 min 23 sec
Details
electron-win-x64 Build #3056 succeeded in 9 min 2 sec
Details
@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki May 4, 2017

Contributor

Thanks for this @juturu 🔍 👍

Contributor

kevinsawicki commented May 4, 2017

Thanks for this @juturu 🔍 👍

@kevinsawicki kevinsawicki deleted the process-metrics branch May 4, 2017

@alexstrat alexstrat referenced this pull request May 5, 2017

Merged

Add OS pid to web-contents #9222

2 of 2 tasks complete
@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke May 5, 2017

Member

This is great, @juturu.

Would you be interested in collaborating with me on a short guide to using these new APIs as well as the app.getAppMemoryInfo() method you just added in #9214?

Member

zeke commented May 5, 2017

This is great, @juturu.

Would you be interested in collaborating with me on a short guide to using these new APIs as well as the app.getAppMemoryInfo() method you just added in #9214?

@juturu

This comment has been minimized.

Show comment
Hide comment
@juturu

juturu May 5, 2017

Contributor

Good idea @zeke. Will try to squeeze this in and report back (may take a week).

Contributor

juturu commented May 5, 2017

Good idea @zeke. Will try to squeeze this in and report back (may take a week).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment