New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support --disk-cache-size flag #9435

Merged
merged 4 commits into from May 15, 2017

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented May 11, 2017

simply parse the command line arguments and pass to net::HttpCache::DefaultBackend

Refs electron-archive/brightray#290
Ported over from electron-archive/brightray#291

/cc @cjld

@kevinsawicki kevinsawicki merged commit c7e6cbc into master May 15, 2017

2 of 8 checks passed

electron-osx-x64 Build #4190 failed in 10 min
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #6626097 queued
Details
electron-linux-ia32 Build #6626098 queued
Details
electron-linux-x64 Build #6626099 queued
Details
electron-mas-x64 Build #4186 succeeded in 8 min 34 sec
Details
electron-win-x64 Build #3137 succeeded in 13 min
Details

@kevinsawicki kevinsawicki deleted the disk-cache-size-flag branch May 15, 2017

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented May 15, 2017

Thanks for this @cjld 👍

@cjld

This comment has been minimized.

Contributor

cjld commented May 16, 2017

@kevinsawicki You are welcome, Electron is great and helps me a lot : P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment