New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for --debug/--debug-brk #9436

Merged
merged 2 commits into from May 15, 2017

Conversation

Projects
None yet
3 participants
@kevinsawicki
Contributor

kevinsawicki commented May 11, 2017

Looks like the old v8 debugger protocol was removed in v8 5.8, nodejs/node#9789 and the debug agent of node was also removed in nodejs/node#12197.

Right now running electron --debug is crashing since there is no debug context available from v8 and so it fails when assigning the context to the node env.

This pull request removes the use of the NodeDebugger class to stop this crash from happening.

This would be a stopgap solution until we can ship support for --inspect/--inspect-brk via #6634.

I've left the classes in there for now, they are just no longer created on startup.

Refs nodejs/node#11421
Refs nodejs/node#12197

Closes #9434

@kevinsawicki kevinsawicki requested review from zcbenz and deepak1556 May 11, 2017

@zeke

This comment has been minimized.

Member

zeke commented May 11, 2017

It looks like there are some references to --debug in the docs:

screen shot 2017-05-11 at 2 28 10 pm

@kevinsawicki kevinsawicki merged commit e708a45 into master May 15, 2017

8 of 9 checks passed

electron-linux-x64 Build #6591953 failed in 103s
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #6591951 succeeded in 97s
Details
electron-linux-ia32 Build #6591952 succeeded in 95s
Details
electron-mas-x64 Build #4160 succeeded in 8 min 30 sec
Details
electron-osx-x64 Build #4164 succeeded in 9 min 23 sec
Details
electron-win-ia32 Build #3145 succeeded in 11 min
Details
electron-win-x64 Build #3119 succeeded in 11 min
Details

@kevinsawicki kevinsawicki deleted the debug-crash branch May 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment