New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --inspect option to debug main process #9473

Merged
merged 12 commits into from May 16, 2017

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented May 15, 2017

Enables node inspector agent when --inspect/--inspect-brk is specified so you can debug the the main process from chrome://inspect

inspect

Fixes #6634

@kevinsawicki kevinsawicki changed the title from Support --inspect option to Support --inspect option to debug main process May 15, 2017

@kevinsawicki kevinsawicki requested a review from deepak1556 May 15, 2017

@deepak1556

LGTM, just a minor change chromium_src/net/test/embedded_server can be removed.

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented May 16, 2017

LGTM, just a minor change chromium_src/net/test/embedded_server can be removed.

Oh, great catch, 👍 🔥

@kevinsawicki kevinsawicki merged commit d66b32b into master May 16, 2017

7 of 9 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #6649605 succeeded in 101s
Details
electron-linux-ia32 Build #6649606 succeeded in 95s
Details
electron-linux-x64 Build #6649607 succeeded in 188s
Details
electron-mas-x64 Build #4217 succeeded in 8 min 44 sec
Details
electron-osx-x64 Build #4220 succeeded in 9 min 50 sec
Details
electron-win-ia32 Build #3196 succeeded in 8 min 49 sec
Details
electron-win-x64 Build #3167 succeeded in 10 min
Details

@kevinsawicki kevinsawicki deleted the dash-dash-inspect branch May 16, 2017

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented May 16, 2017

Thanks for reviewing this @deepak1556 👍 🔍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment