New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node for StartCom/WoSign cert rejection #9499

Merged
merged 1 commit into from May 17, 2017

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented May 16, 2017

This pull request cherry-picks 3 commits from node that were released in 7.6 and 7.8.

This makes https requests via node behave the same as Chrome in terms of rejecting certs from StartCom/WoSign.

This was addressed in Node 7.6 but Electron 1.6.x still runs on Node 7.4.

Before

screen shot 2017-05-16 at 4 38 55 pm

After

screen shot 2017-05-16 at 4 40 16 pm

Background

Commits

/cc @ikkisoft

Refs nodejs/node#9469
Fixes #9457

@kevinsawicki kevinsawicki merged commit 5de881e into 1-6-x May 17, 2017

6 of 7 checks passed

electron-linux-x64 Build #6662008 failed in 123s
Details
electron-linux-arm Build #6658274 succeeded in 108s
Details
electron-linux-ia32 Build #6661855 succeeded in 110s
Details
electron-mas-x64 Build #4219 succeeded in 9 min 40 sec
Details
electron-osx-x64 Build #4222 succeeded in 8 min 56 sec
Details
electron-win-ia32 Build #3198 succeeded in 9 min 39 sec
Details
electron-win-x64 Build #3169 succeeded in 8 min 25 sec
Details

@kevinsawicki kevinsawicki deleted the node-cert-patch branch May 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment