New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport sandbox remote exception fix #9505

Merged
merged 2 commits into from May 17, 2017

Conversation

Projects
None yet
2 participants
@tarruda
Contributor

tarruda commented May 17, 2017

No description provided.

tarruda added some commits May 15, 2017

Fix how rpc-server releases references after page reload
In addition to listening for "render-view-deleted", listen for
"ELECTRON_BROWSER_CONTEXT_RELEASE" synchronous message, which is sent by the
remote module when the page is about to be navigated.

This is required to allow child windows running in the same renderer to
correctly manage remote object references, since `render-view-deleted` is only
called when the renderer exits.

Close #9387

@tarruda tarruda requested a review from kevinsawicki May 17, 2017

@@ -304,6 +304,10 @@ ipcRenderer.on('ELECTRON_RENDERER_RELEASE_CALLBACK', function (event, id) {
callbacksRegistry.remove(id)
})
process.on('exit', () => {
ipcRenderer.sendSync('ELECTRON_BROWSER_CONTEXT_RELEASE')

This comment has been minimized.

@kevinsawicki

kevinsawicki May 17, 2017

Contributor

Just to confirm, this is only needed for sandboxed renderer processes right? Or was this issue also affecting non-sandboxed renderers?

@kevinsawicki

kevinsawicki May 17, 2017

Contributor

Just to confirm, this is only needed for sandboxed renderer processes right? Or was this issue also affecting non-sandboxed renderers?

@kevinsawicki kevinsawicki self-assigned this May 17, 2017

@tarruda

This comment has been minimized.

Show comment
Hide comment
@tarruda

tarruda May 17, 2017

Contributor
Contributor

tarruda commented May 17, 2017

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki May 17, 2017

Contributor

It also affects nativeWindowOpen child windows created with
window.open. For version 1.6.x, it only affects sandbox.

Great, thanks for clarifying 👍

Contributor

kevinsawicki commented May 17, 2017

It also affects nativeWindowOpen child windows created with
window.open. For version 1.6.x, it only affects sandbox.

Great, thanks for clarifying 👍

@kevinsawicki kevinsawicki merged commit c03cb11 into 1-6-x May 17, 2017

4 checks passed

electron-mas-x64 Build #4222 succeeded in 9 min 39 sec
Details
electron-osx-x64 Build #4225 succeeded in 13 min
Details
electron-win-ia32 Build #3201 succeeded in 9 min 42 sec
Details
electron-win-x64 Build #3172 succeeded in 8 min 22 sec
Details

@kevinsawicki kevinsawicki deleted the backport-sandbox-remote-exception-fix branch May 17, 2017

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki May 17, 2017

Contributor

And thanks for backporting this to 1.6

Contributor

kevinsawicki commented May 17, 2017

And thanks for backporting this to 1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment