New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support `gio` as trash implementation #9518

Merged
merged 1 commit into from May 19, 2017

Conversation

Projects
None yet
3 participants
@TingPing
Contributor

TingPing commented May 18, 2017

Ideally this will become the default as gvfs-trash is deprecated and nothing more than a wrapper to gio but at least allow easily opting into the modern method.

Support `gio` as trash implementation
Ideally this will become the default as `gvfs-trash` is deprecated and nothing more than a wrapper to `gio`
but at least allow easily opting into the modern method.

@kevinsawicki kevinsawicki merged commit db6d75c into electron:master May 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented May 19, 2017

Thanks @TingPing for updating this 👍 :shipit:

@eli-schwartz

This comment has been minimized.

eli-schwartz commented Sep 27, 2018

Do you suppose it's about time this becomes the default, since gvfs-trash is finally dropped entirely in the latest gvfs stable release? It's been deprecated since 1.31.1 in October 2016, and completely killed off in 1.37.2 (May of this year).

gvfs 1.38.1 is now in the stable repositories for at least Arch Linux, which means electron has completely broken trash support by default until all users of electron apps set an environment variable that isn't documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment