New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add datalist element support #9535
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f360104
add datalist element view
brenca 4949531
:art: lint fix
brenca a95d6b9
add ability to open popup on second click
brenca 218e28b
minor fixes and enable datalist elements in OSR
brenca d5c038a
ci build fix
brenca df91159
Fix menubar animations being incorrect in RTL layout
brenca 039908a
various fixes for macos
gerhardberger 192cd77
move popup related code to nativewindow
brenca File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ | |
#include "atom/browser/api/save_page_handler.h" | ||
#include "atom/browser/api/trackable_object.h" | ||
#include "atom/browser/common_web_contents_delegate.h" | ||
#include "atom/browser/ui/autofill_popup.h" | ||
#include "content/common/cursors/webcursor.h" | ||
#include "content/public/browser/notification_observer.h" | ||
#include "content/public/browser/notification_registrar.h" | ||
|
@@ -307,6 +308,9 @@ class WebContents : public mate::TrackableObject<WebContents>, | |
// content::WebContentsObserver: | ||
void BeforeUnloadFired(const base::TimeTicks& proceed_time) override; | ||
void RenderViewCreated(content::RenderViewHost*) override; | ||
void RenderFrameCreated(content::RenderFrameHost*) override; | ||
void RenderFrameHostChanged(content::RenderFrameHost*, | ||
content::RenderFrameHost*) override; | ||
void RenderViewDeleted(content::RenderViewHost*) override; | ||
void RenderProcessGone(base::TerminationStatus status) override; | ||
void DocumentLoadedInFrame( | ||
|
@@ -374,6 +378,12 @@ class WebContents : public mate::TrackableObject<WebContents>, | |
// Called when we receive a CursorChange message from chromium. | ||
void OnCursorChange(const content::WebCursor& cursor); | ||
|
||
void OnShowAutofillPopup(int routing_id, | ||
const gfx::RectF& bounds, | ||
const std::vector<base::string16>& values, | ||
const std::vector<base::string16>& labels); | ||
void OnHideAutofillPopup(); | ||
|
||
// Called when received a message from renderer. | ||
void OnRendererMessage(const base::string16& channel, | ||
const base::ListValue& args); | ||
|
@@ -397,6 +407,7 @@ class WebContents : public mate::TrackableObject<WebContents>, | |
|
||
std::unique_ptr<AtomJavaScriptDialogManager> dialog_manager_; | ||
std::unique_ptr<WebViewGuestDelegate> guest_delegate_; | ||
AutofillPopup* autofill_popup_; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems to be leaked? It can be managed with |
||
|
||
// The host webcontents that may contain this webcontents. | ||
WebContents* embedder_; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WebContents
should not handle GUI related code,autofill_popup_
and its related code should be moved toNativeWindow
instead.