New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use last selected directory when using default file name in dialog.showSaveDialog() #9588

Merged
merged 1 commit into from Jun 14, 2017

Conversation

Projects
None yet
2 participants
@poiru
Member

poiru commented May 25, 2017

Prior to this change, attempting to use dialog.showSaveDialog({ defaultPath: 'foo.png' }) would open the save dialog to the current directory with the default file name set to foo.png. We now use the last selected directory instead of the current directory.

Absolute paths are not affected by this change.

@poiru poiru requested a review from kevinsawicki May 25, 2017

Use last selected directory when using default file name in dialog.sh…
…owSaveDialog()

Prior to this change, attempting to use
`dialog.showSaveDialog({ defaultPath: 'foo.png' })` would open the save
dialog to the current directory with the default file name set to
`foo.png`. We now use the last selected directory instead of the current
directory.

Absolute paths are not affected by this change.

@kevinsawicki kevinsawicki merged commit dae27de into master Jun 14, 2017

5 of 6 checks passed

electron-mas-x64 Build #4320 failed in 11 min
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-osx-x64 Build #4324 succeeded in 14 min
Details
electron-win-ia32 Build #3295 succeeded in 8 min 30 sec
Details
electron-win-x64 Build #3271 succeeded in 20 min
Details
@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Jun 14, 2017

Thanks @poiru 👍 🚢

@kevinsawicki kevinsawicki deleted the poiru/dialog-default-file-name branch Jun 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment