New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #8724 from electron/defer_load_url" #9674

Merged
merged 1 commit into from Jun 5, 2017

Conversation

Projects
None yet
3 participants
@deepak1556
Copy link
Member

deepak1556 commented Jun 5, 2017

There are edge cases involving pending navigation entries that weren't accounted for in the original PR. #8700 can be fixed with plznavigate move.

Fixes #9121

Revert "Merge pull request #8724 from electron/defer_load_url"
  Possible cause for #9121

This reverts commit 886b47e, reversing
changes made to 479af3c.

@kevinsawicki kevinsawicki self-assigned this Jun 5, 2017

@kevinsawicki kevinsawicki merged commit 352a926 into master Jun 5, 2017

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-mas-x64 Build #4383 succeeded in 10 min
Details
electron-osx-x64 Build #4389 succeeded in 9 min 59 sec
Details
electron-win-ia32 Build #3359 succeeded in 14 min
Details
electron-win-x64 Build #3336 succeeded in 10 min
Details

@kevinsawicki kevinsawicki deleted the revert_8724 branch Jun 5, 2017

@kevinsawicki

This comment has been minimized.

Copy link
Contributor

kevinsawicki commented Jun 5, 2017

Thanks @deepak1556 👍

@snene

This comment has been minimized.

Copy link

snene commented Jun 6, 2017

Will this crash fix be part of 1.7.3? Any idea when 1.7.3 will be released?

@kevinsawicki

This comment has been minimized.

Copy link
Contributor

kevinsawicki commented Jun 6, 2017

Will this crash fix be part of 1.7.3? Any idea when 1.7.3 will be released?

Yes, will be in 1.7.3, aiming to be released this Thursday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment