New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where alwaysOnTop window disappears when restore… #9695

Merged
merged 4 commits into from Jul 14, 2017

Conversation

Projects
None yet
4 participants
@shubham2892
Contributor

shubham2892 commented Jun 7, 2017

Fixes #9170
Reset the custom level when windowWillMiniaturize fires and then restores it when windowDidDeminiaturize fires as suggested in issue.

Before:
Before Gif

After:
After Gif

shubham2892 added some commits Jun 7, 2017

@chabou

chabou approved these changes Jun 25, 2017

@kevinsawicki

Looks good, left a few minor comments, thanks for fixing this.

@@ -75,6 +75,7 @@ @interface AtomNSWindowDelegate : NSObject<NSWindowDelegate> {
@private
atom::NativeWindowMac* shell_;
bool is_zooming_;
int level_;

This comment has been minimized.

@kevinsawicki

kevinsawicki Jul 13, 2017

Contributor

I think this should be initialized in initWithShell like the other variables.

@kevinsawicki

kevinsawicki Jul 13, 2017

Contributor

I think this should be initialized in initWithShell like the other variables.

Show outdated Hide outdated spec/api-browser-window-spec.js Outdated
@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Jul 14, 2017

Contributor

Thanks for fixing this @shubham2892 👍 🚢

Contributor

kevinsawicki commented Jul 14, 2017

Thanks for fixing this @shubham2892 👍 🚢

@kevinsawicki kevinsawicki merged commit 0a71a9b into electron:master Jul 14, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment